Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(matchexpr): correct invalidation logic #255

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #248

How to manually test:

  1. ./mvnw -Dtest=RulesTest clean test and check that the exception is not logged

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 1/22/2024, 11:32:35 AM. View Actions Run.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7614315926

1 similar comment
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7614315926

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrewazores andrewazores force-pushed the matchexpr-cache-invalidate branch from 1ca73fd to a3e97ff Compare January 22, 2024 19:52
@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 1/22/2024, 2:52:49 PM. View Actions Run.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7616589277

1 similar comment
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7616589277

@andrewazores andrewazores merged commit a54e7f3 into cryostatio:main Jan 22, 2024
8 checks passed
@andrewazores andrewazores deleted the matchexpr-cache-invalidate branch January 22, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants