Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grafana): implement endpoint for 'view in grafana' of archived recordings #287

Merged
merged 9 commits into from
Feb 16, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #2

Description of the change:

Implements endpoints for "View in Grafana" feature upon archived recordings.

Motivation for the change:

Previously, 3.0 only supported "View in Grafana" on active recordings.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. Find or start an active running recording
  3. Archive the recording, go to Archives view
  4. Find the archived recording and "View in Grafana". Verify that the Grafana dashboard appears and has sensible data content.

@andrewazores andrewazores added feat New feature or request safe-to-test labels Feb 14, 2024
@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 2/14/2024, 5:44:30 PM. View Actions Run.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7908355062

1 similar comment
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7908355062

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 2/15/2024, 9:24:15 AM. View Actions Run.

Copy link

CI build and push: All tests pass ✅ (JDK21)
https://github.com/cryostatio/cryostat3/actions/runs/7917426127

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 2/15/2024, 9:27:44 AM. View Actions Run.

Copy link

CI build and push: All tests pass ✅ (JDK21)
https://github.com/cryostatio/cryostat3/actions/runs/7917477723

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/7917426127

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/7917477723

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 2/15/2024, 9:39:58 AM. View Actions Run.

Copy link

CI build and push: All tests pass ✅ (JDK21)
https://github.com/cryostatio/cryostat3/actions/runs/7917643522

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/7917643522

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 2/15/2024, 9:54:35 AM. View Actions Run.

Copy link

CI build and push: All tests pass ✅ (JDK21)
https://github.com/cryostatio/cryostat3/actions/runs/7917830667

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/7917830667

@andrewazores
Copy link
Member Author

cryostat3-archived-grafana-2024-02-15_12.57.40.mp4

@andrewazores
Copy link
Member Author

/build_test

Copy link

Workflow started at 2/15/2024, 2:23:17 PM. View Actions Run.

Copy link

CI build and push: All tests pass ✅ (JDK21)
https://github.com/cryostatio/cryostat3/actions/runs/7921197997

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/7921197997

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores merged commit afd746f into cryostatio:main Feb 16, 2024
8 checks passed
@andrewazores andrewazores deleted the archived-grafana branch February 16, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants