-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grafana): implement endpoint for 'view in grafana' of archived recordings #287
Conversation
/build_test |
Workflow started at 2/14/2024, 5:44:30 PM. View Actions Run. |
CI build and push: All tests pass ✅ |
1 similar comment
CI build and push: All tests pass ✅ |
ad68def
to
6451d42
Compare
/build_test |
Workflow started at 2/15/2024, 9:24:15 AM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
/build_test |
Workflow started at 2/15/2024, 9:27:44 AM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
CI build and push: All tests pass ✅ (JDK17) |
CI build and push: All tests pass ✅ (JDK17) |
31af088
to
c371f03
Compare
/build_test |
Workflow started at 2/15/2024, 9:39:58 AM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
CI build and push: All tests pass ✅ (JDK17) |
/build_test |
Workflow started at 2/15/2024, 9:54:35 AM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
CI build and push: All tests pass ✅ (JDK17) |
cryostat3-archived-grafana-2024-02-15_12.57.40.mp4 |
a440dde
to
8b7c3cf
Compare
/build_test |
Workflow started at 2/15/2024, 2:23:17 PM. View Actions Run. |
CI build and push: All tests pass ✅ (JDK21) |
CI build and push: All tests pass ✅ (JDK17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #2
Description of the change:
Implements endpoints for "View in Grafana" feature upon archived recordings.
Motivation for the change:
Previously, 3.0 only supported "View in Grafana" on active recordings.
How to manually test: