Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Archived Recordings): Archived Recordings tables improperly react to "Recording Saved" notifications #485

Merged

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented May 30, 2024

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #441

Description of the change:

This change will update the Archived Recordings table with the correct data (i.e Name and Size), when Recordings are created and archived with Automated Rules.

Motivation for the change:

Mentioned earlier by @andrewazores #441

How to manually test:

  1. checkout on this PR and run smoketest.
  2. create an Automated Rule -> Automated Rules -> Create
  "id": 1,
  "name": "test",
  "description": "",
  "matchExpression": "target.connectUrl.contains('localhost:0')",
  "eventSpecifier": "template=Profiling,type=TARGET",
  "archivalPeriodSeconds": 10,
  "initialDelaySeconds": 0,
  "preservedArchives": 3,
  "maxAgeSeconds": 300,
  "maxSizeBytes": 0,
  "enabled": true
}
  1. go to Recordings -> select the localhost:0 as the target -> go to Archived Recordings tab
  2. the Automated Rule should create Archived Recordings
  3. verify that all data is available and valid (especially Name and Size)

@aali309 aali309 self-assigned this May 30, 2024
@aali309 aali309 force-pushed the improperlyReactToRecordingSaved branch from 96db6b1 to 031a160 Compare May 30, 2024 16:03
@aali309
Copy link
Contributor Author

aali309 commented May 30, 2024

/build_test

Copy link

Workflow started at 5/30/2024, 12:04:08 PM. View Actions Run.

Copy link

No GraphQL schema changes detected.

Copy link

No OpenAPI schema changes detected.

Copy link

CI build and push: All tests pass ✅ (JDK17)
https://github.com/cryostatio/cryostat3/actions/runs/9305649009

@aali309 aali309 requested a review from andrewazores May 30, 2024 16:18
@andrewazores andrewazores force-pushed the improperlyReactToRecordingSaved branch from 031a160 to 91dda27 Compare May 30, 2024 18:15
@andrewazores andrewazores merged commit dd420de into cryostatio:main May 30, 2024
7 checks passed
@aali309 aali309 deleted the improperlyReactToRecordingSaved branch May 30, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] Archived recordings tables improperly react to "Recording Saved" notifications
2 participants