Public input hash with poseidon-circuit #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Poseidon-circuit to be used for hashing the public input (a naive recursive hash implementation). The Sponge hash would be a better approach but API is currently not usable somehow.
In addition, please note that the internal hash used by halo2 for verifying vk is currently disabled in the 'plonk.rs' file. This was done because the previous approach of stringifying the entire vk key for hashing was too memory-intensive. While a new hash strategy is required for vk verification, this is not an urgent issue that needs to be addressed immediately.