move signing to external wallet

[DougAnderson444]

multicid/src/vlad.rs

Line 186 in 891a9ba

let sv = mk.sign_view()?;

This signing needs to be done from an external function.

[DougAnderson444]

I have this change compelted here but I will wait for cryptidtech/multikey#3 and cryptidtech/multisig#2 to resolve before opening the PR, and the dependency tree is downstream from those deps.

[DougAnderson444]

nudge @dhuseby

[dhuseby]

I just merged the multisig PR. Thanks

[dhuseby]

And poked Mike about the blsful update to crates.io

[dhuseby]

just fixed the multikey one

[dhuseby]

@DougAnderson444 I've been thinking for some time that there should be a standard protocol for activating external cryptographic services. Here's a proposal I made years ago for abstracting the cryptographic operations out of git: https://github.com/cryptidtech/git-cryptography-protocol/blob/main/Git%20Cryptography%20Protocol.md

It would be cool to generalize the proposal, update the spec, and implement it in Multikey/Multisig

[dhuseby]

FIDO is similar I think.

[DougAnderson444]

Yeah that's interesting. I think ultimately something like this is what is needed as part of the evolution.

I'll give it some thought. Implementing something like that would require an overhaul to the public API, likely having the user implement some signing trait that returns a future, instead of using a closure like it does now.