Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: new evm tx format not integrated #1414

Merged
merged 10 commits into from
May 3, 2024

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 29, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • New Features
    • Integrated a new EVM transaction format to enhance Ethereum Virtual Machine transactions.
    • Updated transaction receipt handling in the CronosAPI to improve data access efficiency.
  • Enhancements
    • Updated module versions and hashes for dependencies in gomod2nix.toml and nix configurations.
    • Modified the ibc_multi_transfer function in integration tests to limit user generation, enhancing test performance.
  • Bug Fixes
    • Changed the transfer mechanism in IBC transfer tests for improved reliability.
  • Refactor
    • Updated the handling of transaction data in various backend services to streamline processes and reduce errors.
  • Documentation
    • Added comments in integration tests to indicate areas needing more users after batch fixes.

@yihuang yihuang requested a review from a team as a code owner April 29, 2024 03:12
@yihuang yihuang requested review from JayT106 and devashishdxt and removed request for a team April 29, 2024 03:12
Copy link
Contributor

coderabbitai bot commented Apr 29, 2024

Walkthrough

This update primarily enhances the Ethereum Virtual Machine (EVM) integration, with changes across multiple files reflecting updates in transaction handling, module versions, and testing adjustments. The modifications include updates to dependency versions, changes in function parameters, and the introduction of new transaction formats, aiming to improve performance and compatibility within the blockchain framework.

Changes

Files Changes
CHANGELOG.md, gomod2nix.toml, nix/default.nix, nix/sources.json Updated module versions, hashes, and repository details.
x/cronos/keeper/evm.go, x/cronos/keeper/evm_hooks.go, x/cronos/keeper/evm_hooks_test.go, x/cronos/keeper/grpc_query.go, x/cronos/types/interfaces.go, x/cronos/rpc/api.go Modifications in EVM transaction handling and method parameters.
integration_tests/ibc_utils.py, integration_tests/test_ibc_rly.py Adjustments in test functions and user generation limits for IBC transfers.

🐰🌟
In the world of code, where bytes align,
A rabbit hopped, through lines, divine.
With each jump, a change was made,
In EVM's realm, new paths were laid.
Celebrate we do, with a hop and cheer,
For updates that make the future clear!
🌟🐰


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 2143307 and 92ac889.
Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
Files selected for processing (3)
  • gomod2nix.toml (1 hunks)
  • nix/sources.json (1 hunks)
  • x/cronos/rpc/api.go (4 hunks)
Files skipped from review as they are similar to previous changes (3)
  • gomod2nix.toml
  • nix/sources.json
  • x/cronos/rpc/api.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 35.82%. Comparing base (662c643) to head (92ac889).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1414      +/-   ##
==========================================
+ Coverage   35.80%   35.82%   +0.02%     
==========================================
  Files         136      136              
  Lines        9879     9873       -6     
==========================================
  Hits         3537     3537              
+ Misses       5945     5939       -6     
  Partials      397      397              
Files Coverage Δ
x/cronos/keeper/evm.go 60.18% <100.00%> (ø)
x/cronos/keeper/evm_hooks.go 41.66% <100.00%> (ø)
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/cronos/rpc/api.go 0.49% <0.00%> (+<0.01%) ⬆️

@yihuang yihuang requested a review from mmsqe April 29, 2024 03:40
go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Out of diff range and nitpick comments (3)
CHANGELOG.md (3)

Line range hint 14-17: Standardize the formatting of entries in the "Improvements" section to maintain consistency.

- * (test) [#1380](https://github.com/crypto-org-chain/cronos/pull/1380) Upgrade cosmovisor to 1.5.0 in integration test.
- * (versiondb) [#1379](https://github.com/crypto-org-chain/cronos/pull/1379) Flush versiondb when graceful shutdown, make rocksdb upgrade smooth.
- * (store) [#1378](https://github.com/crypto-org-chain/cronos/pull/1378) Upgrade rocksdb to `v8.11.3`.
- * (versiondb) [#1387](https://github.com/crypto-org-chain/cronos/pull/1387) Add dedicated config section for versiondb, prepare for sdk 0.50 integration.
+ * [#1380](https://github.com/crypto-org-chain/cronos/pull/1380) Upgrade Cosmovisor to 1.5.0 in integration test.
+ * [#1379](https://github.com/crypto-org-chain/cronos/pull/1379) Flush VersionDB when graceful shutdown, make RocksDB upgrade smooth.
+ * [#1378](https://github.com/crypto-org-chain/cronos/pull/1378) Upgrade RocksDB to `v8.11.3`.
+ * [#1387](https://github.com/crypto-org-chain/cronos/pull/1387) Add dedicated config section for VersionDB, prepare for SDK 0.50 integration.

Line range hint 23-23: Clarify the description of the bug fix in PR #1397 to enhance understanding.

- * (rpc) [#1397](https://github.com/crypto-org-chain/cronos/pull/1397) Avoid panic on invalid elasticity_multiplier.
+ * [#1397](https://github.com/crypto-org-chain/cronos/pull/1397) Modify RPC to handle invalid elasticity_multiplier values gracefully, avoiding system panic.

Line range hint 27-28: Ensure consistency in the presentation of feature descriptions for better readability.

- * [#1406](https://github.com/crypto-org-chain/cronos/pull/1406) Add set-encryption-key for encryption module.
- * [#1411](https://github.com/crypto-org-chain/cronos/pull/1411) Add encrypt and decrypt cmds for message.
+ * [#1406](https://github.com/crypto-org-chain/cronos/pull/1406) Add 'set-encryption-key' functionality to the encryption module.
+ * [#1411](https://github.com/crypto-org-chain/cronos/pull/1411) Introduce 'encrypt' and 'decrypt' commands for messaging.

CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

integration_tests/ibc_utils.py Show resolved Hide resolved
@mmsqe mmsqe enabled auto-merge May 3, 2024 02:50
@mmsqe mmsqe added this pull request to the merge queue May 3, 2024
Merged via the queue into crypto-org-chain:main with commit 6f49e3c May 3, 2024
44 of 45 checks passed
@yihuang yihuang deleted the tx-format branch May 3, 2024 05:59
alienc0der pushed a commit to alienc0der/supernova that referenced this pull request Jun 8, 2024
* Problem: new evm tx format not integrated

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* update deps

* update go

* use rly

* less users

* fix

* update deps

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants