Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Python snippets be updated for (or checked against) Python 3? #353

Open
dato opened this issue Jan 19, 2019 · 1 comment
Open

Should Python snippets be updated for (or checked against) Python 3? #353

dato opened this issue Jan 19, 2019 · 1 comment

Comments

@dato
Copy link
Contributor

dato commented Jan 19, 2019

Hi—

Now that Python 3 is widely used, it might be a good idea to ensure Python snippets work with this version?

I’m submitting this issue mostly just to verify if you’d accept a PR; I might have time to work on this.

In many cases, changes are somewhat cosmetic only, like "crypto101"b"crypto101" in the hashing examples.

@lvh
Copy link
Member

lvh commented Jan 19, 2019

I'd be happy to accept a PR but last I checked plenty of changes get quite a bit more complicated -- like indexing a bytearray resulting in an int, not a bytearray of length 1. But sure, I'd be fine with Python3-first :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants