Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show different icons for users and groups in vault member list #173

Open
2 tasks done
SailReal opened this issue Nov 10, 2022 · 8 comments
Open
2 tasks done

Show different icons for users and groups in vault member list #173

SailReal opened this issue Nov 10, 2022 · 8 comments
Labels
type:bug Something isn't working

Comments

@SailReal
Copy link
Member

Please agree to the following

Summary

App should generate different kind of icon for users and groups if no icon is set to better distinguish these type of authorities.

System Setup

- Hub: 1.0.0
- Keycloak: x
- Cryptomator (Desktop/Android/iOS): x

Steps to Reproduce

  1. Create a user and a group in Keycloak
  2. Create a vault
  3. Add members to this vault

Expected Behavior

Users and groups can be distinguished.

Actual Behavior

Users and groups currently share the same mechanism how the icons are generated.

Screenshot from 2022-11-10 09-47-11

Reproducibility

Always

Relevant Log Output

No response

Anything else?

No response

@SailReal SailReal added the type:bug Something isn't working label Nov 10, 2022
@tobihagemann
Copy link
Member

tobihagemann commented Nov 10, 2022

I guess I failed my task at #150 then. 😂

Edit: They are different! Apparently, not different enough?

@SailReal
Copy link
Member Author

Oh I see 😅, hmm difficult to say but I think so, Armin and I didn't notice it.

@infeo
Copy link
Member

infeo commented Nov 10, 2022

It is nowwhere documented. How should a normal user be able to differentiate from the beginning what a group is and what only a user?

@tobihagemann
Copy link
Member

Alternative solution: Indicate via text that it is a group?

@infeo
Copy link
Member

infeo commented Nov 11, 2022

On top of the icon or next to it?
g_group

@tobihagemann
Copy link
Member

I would suggest to use the full word "Group" either below the group name or right-aligned at the same height. But use a brighter color and maybe a smaller font size, similar to the vault list with "vault name" and "description".

@SailReal
Copy link
Member Author

I checked some apps that support users/groups and nearly all of them following the attached icons of Signal and Threema where the user icon is doubled. In our case we could double the generated picture?

Threema user/group icon screenshot

Signal group icon screenshot

@infeo
Copy link
Member

infeo commented Nov 15, 2022

After a discussion we decided the following:

  • if the Authority is a group, it's ui element should be enhanced by an additional field displaying the size of the group
  • the field text should be gray and in a smaller font than the group name
  • the field is placed on the right of the group name

Edit: This holds for the search field and the member list.

Example:
Group_mockup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants