Revert native sql unlock before we ship the refactored access management #222
Comments
SailReal
changed the title
SailReal
changed the title
|
Unfortunately, Updating Quarkus to 3.4.3 does not fix this, although Hibernate is now at 6.2.9 and 6.2.8 and 6.3.0 should fix it. Still getting |
|
For the record: Quarkus with v3.5.0 and Hibernate in version 6.2.13 does not fix the problem as well. |
|
During my work on #252 we noticed that we added further This is our SELECT t.device_id, t.vault_id, t.jwe
FROM access_token_legacy t
INNER JOIN device_legacy d ON d.id = t.device_id
INNER JOIN effective_vault_access a ON a.vault_id = t.vault_id AND a.authority_id = d.owner_id
WHERE t.vault_id = :vaultId AND d.id = :deviceId AND d.owner_id = :userIdHibernate translates this to: SELECT
t.device_id,
t.vault_id,
t.jwe
FROM
access_token_legacy t
INNER JOIN
device_legacy d
ON d.id = t.device_id
INNER JOIN
effective_vault_access a
ON a.vault_id = t.vault_id
AND a.authority_id = d.owner_id
WHERE
t.vault_id = ?
AND d.id = ?
AND d.owner_id = ? I converted this to the following normal SELECT t
FROM LegacyAccessToken t
INNER JOIN LegacyDevice d ON d.id = t.id.deviceId
INNER JOIN EffectiveVaultAccess p ON t.id.vaultId = p.id.vaultId AND d.ownerId = p.id.authorityId
WHERE t.id.vaultId = :vaultId AND t.id.deviceId = :deviceId AND d.ownerId = :userIdWhich is translated to this: select
l1_0."device_id",
l1_0."vault_id",
l1_0."jwe"
from
"access_token_legacy" l1_0
join
"device_legacy" l2_0
on l2_0."id"=l1_0."device_id"
join
"effective_vault_access" e1_0
on l1_0."vault_id"=e1_0."vault_id"
and l2_0."owner_id"=e1_0."authority_id"
where
l1_0."vault_id"=?
and l1_0."device_id"=?
and l2_0."owner_id"=? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please agree to the following
Summary
Revert 1baf734 before we ship the refactored access management to remove the native call which can introduce major problems in the future.
Motivation
Make sure that the introduced native unlock call 1baf734 never makes it into production. I strongly suspect that Hibernate ORM will be at version 6.2.8 or 6.3.0 until we ship the refactored access management.
This issue should just remind us to undo that commit before shipping.
Considered Alternatives
We should not downgrade Quarkus to v3.1.0 because of #220
Downgrading only the hibernate dependency wasn't successfully.
Anything else?
Regarding the issue itself, see quarkusio/quarkus#35386
The text was updated successfully, but these errors were encountered: