Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File based QuickAccess impls: Atomic move not supported #97

Open
infeo opened this issue Nov 11, 2024 · 0 comments
Open

File based QuickAccess impls: Atomic move not supported #97

infeo opened this issue Nov 11, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@infeo
Copy link
Member

infeo commented Nov 11, 2024

The filebased QuickAccess impls use the following pattern to add/or remove an entry:

  1. Copy file to tmp dir
  2. Edit file
  3. Replace original file with tmp-file atomically

The latter might not be possible atomically (e.g. /tmp/ and /home/user/... can be on different disks/partitions). The error message:

Caused by: java.nio.file.AtomicMoveNotSupportedException: /tmp/user-places.xbel.cryptomator.tmp -> /home/user/.local/share/user-places.xbel: Invalid cross-device link

If atomic move is not supported, we could relax the condition on a second try.

@infeo infeo added the enhancement New feature or request label Nov 11, 2024
@infeo infeo self-assigned this Nov 11, 2024
@infeo infeo added this to the next milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant