Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untransformed event-handler: 'js-url-0.js' #6

Open
esbena opened this issue Jan 4, 2017 · 0 comments
Open

Untransformed event-handler: 'js-url-0.js' #6

esbena opened this issue Jan 4, 2017 · 0 comments
Assignees

Comments

@esbena
Copy link
Member

esbena commented Jan 4, 2017

The LogFileTransformer needs to make href-attribute (or the more general javascript:) event handlers be logged with a properly transformed source location.

See example in chromeExperiments/bomomo.html:

<a href="javascript:saveCanvas()" class="toolbarButton" id="toolbarButtonSave" title=""><img src="./bomomo_files/save.png" alt=""></a>

Log:

{"name":{"valueKind":"concrete-string","value":"saveCanvas"},"sourceLocation":{"fileName":"js-url-0_orig_.js","columnNumber":"1","lineNumber":"1"},"value":{"valueKind":"abstract-object","value":{"objectKind":"allocation-site","allocationSite":{"fileName":"bomomo.html","columnNumber":1,"lineNumber":450}}},"entryKind":"read-variable"}

Problem:
The {"fileName":"js-url-0_orig_.js","columnNumber":"1","lineNumber":"1"} should be the inlined HTML source position: bomomo.html:2848:29 instead.

@barslev can you take a look? It should be similar to the other transformations that are already being done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants