support channel permission unions for plugins

[rob-3]

[5:45 PM] rob-3: !8ball
[5:45 PM] Lion: Please use this command in a Public channel.
Here are 3 of the 47 supported channel(s): 
general,
memes,
programming_help.

I think 8ball should work in #bot-commands. Once I finish rewriting it, I will fix this bug myself if it still exists.

[tanndlin]

This is intended
The channel permission is public

Channel permission is checked here at runtime

Channel types are defined by name in Constants.ts

However, I would be down for changing the way this is defined as it could be useful to have a channel with multiple types
(ie #bot_commands could be public and bot)

[joeydotdev]

for some historic context- we defined bot commands as not a public chan because we didn't want to start conversation in that channel/wanted to keep the messages sent in that chan strictly for class registration/garage status. we believed commands that lean more social should stick to the other public chans

[tanndlin]

for some historic context- we defined bot commands as not a public chan because we didn't want to start conversation in that channel/wanted to keep the messages sent in that chan strictly for class registration/garage status. we believed commands that lean more social should stick to the other public chans

Agree with this

[tanndlin]

However, I would be down for changing the way this is defined as it could be useful to have a channel with multiple types (ie #bot_commands could be public and bot)

Or maybe less intrusively, the ability to union types for a certain plugin
Just something like an array

public permission: ChannelType = [ChannelType.Public, ChannelType.Bot];