asg/mem-alloc: Update README and fix test script name
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razvand
added
kind/improve
Alex-deVis
reviewed
Oct 31, 2023
There was a problem hiding this comment.
Besides the inline comment, please remove creation of tests/out/ directory (i.e. run_tests.py line 461) as it is no longer used.
Alex-deVis
approved these changes
Oct 31, 2023
Update `README.md` with details on using `grade.sh` and `make lint`. Use `run_tests.py` instead of `run-tests.py` in `README.md`. Signed-off-by: Razvan Deaconescu <[email protected]>
Use `run_tests.py` instead of `run-tests.py` in `tests/Makefile`. Signed-off-by: Razvan Deaconescu <[email protected]>
`out/` directory is not longer used by tests. Signed-off-by: Razvan Deaconescu <[email protected]>
razvand
force-pushed
the
razvand/asg/mem-alloc/fixes
branch
from
40781f7 to
d80617c
Compare
Use correct and complete targets for `lint` target in `tests/Makefile`. Signed-off-by: Razvan Deaconescu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
README.mdwith testing updates. Apply fixes intests/Makefile.