Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chapter/software-stack: Restructure repo according to updated methodology #55

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

teodutu
Copy link

@teodutu teodutu commented Mar 5, 2024

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

  • Move all content to the chapers/ folder
  • Separate between reading/, guides/, drills/ etc.
  • Modify config.yaml to reflect the changes above
  • Update labeler.yml to the new structure
  • Fix broken links and paths
  • Copy the generic slides.mk into chapters/software-stack/Makefile to
    make the chapter more self-contained

@teodutu teodutu self-assigned this Mar 5, 2024
@teodutu teodutu added the needs-rendering The PR makes changes to the website that need to be rendered label Mar 5, 2024
@teodutu teodutu force-pushed the restructure-software-stack branch from 6b4dc80 to 2502e44 Compare March 5, 2024 23:39
@teodutu teodutu marked this pull request as ready for review March 5, 2024 23:39
@teodutu teodutu added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Mar 5, 2024
@teodutu teodutu force-pushed the restructure-software-stack branch from 2502e44 to 9bfa47a Compare March 5, 2024 23:42
@teodutu teodutu added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

@github-actions github-actions bot added area/content Content (Markdown) update area/infra Update to infrastructure / scripts kind/new New content / item labels Mar 6, 2024
@teodutu teodutu force-pushed the restructure-software-stack branch from 9bfa47a to 4241262 Compare March 6, 2024 09:26
@teodutu teodutu added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

…logy

- Move all content to the `chapers/` folder
- Separate between `reading/`, `guides/`, `drills/` etc.
- Modify `config.yaml` to reflect the changes above
- Update `labeler.yml` to the new structure
- Fix broken links and paths
- Copy the generic `slides.mk` into `chapters/software-stack/Makefile` to
make the chapter more self-contained

Signed-off-by: Teodor Dutu <[email protected]>
@teodutu teodutu force-pushed the restructure-software-stack branch from 4241262 to 89a3d2b Compare March 6, 2024 09:34
@Grizzlly
Copy link

Why does the link say page not found?

@teodutu teodutu added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Mar 16, 2024
Copy link

1 similar comment
Copy link

@teodutu
Copy link
Author

teodutu commented Mar 16, 2024

Now it's working @Grizzlly. I think the 404 was because I had made another push to this branch and hadn't reset the needs-rendering tag.

Copy link

@Grizzlly Grizzlly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teodutu teodutu merged commit c58a60b into cs-pub-ro:main Mar 17, 2024
4 of 5 checks passed
@teodutu teodutu deleted the restructure-software-stack branch March 17, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/content Content (Markdown) update area/infra Update to infrastructure / scripts kind/new New content / item needs-rendering The PR makes changes to the website that need to be rendered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants