Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general/drills: Add "FaaS service" written task as exam #57

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

vladiouz
Copy link

@vladiouz vladiouz commented Mar 8, 2024

edited config.yaml and faas-service.md

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

@vladiouz vladiouz added the needs-rendering The PR makes changes to the website that need to be rendered label Mar 8, 2024
@vladiouz vladiouz requested a review from teodutu March 8, 2024 18:21
Copy link

github-actions bot commented Mar 8, 2024

@github-actions github-actions bot added topic/general Related to multiple chapters kind/improve Improve / Update existing content / item kind/new New content / item labels Mar 9, 2024
Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is OK. Good job!

Now update your commit description to be less vague. Follow the example from this commit [1] and use imperative verbs, not the past tense of the indicative mood.

Second, when you create a PR, you've already seen a template description pop up. Move the description of your changes under the Description of changes heading.

[1] 9c113e8

chapters/general/drills/tasks/faas-service.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added area/infra Update to infrastructure / scripts area/tasks Update to tasks labels Mar 17, 2024
@vladiouz vladiouz self-assigned this Mar 18, 2024
edited config.yaml and faas-service.md

Signed-off-by: Petru-Vlad Ionescu <[email protected]>
@vladiouz vladiouz force-pushed the add-faas-service-exam branch from c0f49ee to 5f4d07a Compare March 18, 2024 15:48
@vladiouz vladiouz requested a review from teodutu March 18, 2024 15:49
@teodutu teodutu merged commit b073e9e into cs-pub-ro:main Mar 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra Update to infrastructure / scripts area/tasks Update to tasks kind/improve Improve / Update existing content / item kind/new New content / item needs-rendering The PR makes changes to the website that need to be rendered topic/general Related to multiple chapters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants