Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #96

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix typo #96

merged 1 commit into from
Oct 14, 2024

Conversation

mucel29
Copy link

@mucel29 mucel29 commented Oct 14, 2024

Prerequisite Checklist

  • [ x] Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Follow our guidelines [1] to improve your commit message so that checkpatch passes [2]. Modify its title to something like chapters/software-stack: Fix typo in common-functions task + a description of the typo, and sign. You can do this with git commit --amend -s after you've configured your username and email as shown at the beginning of [1]. After that, I'll merge your changes.

[1] https://github.com/cs-pub-ro/operating-systems/blob/main/CONTRIBUTING.md#commits
[2] https://github.com/cs-pub-ro/operating-systems/actions/runs/11321752225/job/31489064010?pr=96

@mucel29 mucel29 force-pushed the fix-typo branch 3 times, most recently from cdaddee to 25347e2 Compare October 14, 2024 09:54
Typo in make command to generate files.
Changed 'make skells' to 'make skels' to match Makefile.

Signed-off-by: mucel29 <[email protected]>
@mucel29 mucel29 requested a review from teodutu October 14, 2024 10:00
@github-actions github-actions bot added area/tasks Update to tasks topic/software-stack Related to "Software Stack" chapter labels Oct 14, 2024
@teodutu teodutu merged commit aaca59a into cs-pub-ro:main Oct 14, 2024
3 checks passed
@mucel29 mucel29 deleted the fix-typo branch November 4, 2024 06:51
@teodutu teodutu added the student-contrib Fix or improvement made by a student label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tasks Update to tasks student-contrib Fix or improvement made by a student topic/software-stack Related to "Software Stack" chapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants