Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-lint project files #28

Merged
merged 5 commits into from
Aug 17, 2024
Merged

De-lint project files #28

merged 5 commits into from
Aug 17, 2024

Conversation

mdpiper
Copy link
Member

@mdpiper mdpiper commented Aug 16, 2024

This PR applies current linting and formatting rules to the repo files in preparation for a move to pre-commit (see #27).

@mdpiper
Copy link
Member Author

mdpiper commented Aug 16, 2024

The coverage workflow is failing. I'll fix it in a subsequent PR.

@mdpiper mdpiper marked this pull request as ready for review August 16, 2024 21:58
It was in setup.py, but got moved to pyproject.toml in d1affcf.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10427734608

Details

  • 2 of 6 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+52.8%) to 52.795%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bmi_geotiff/bmi.py 2 6 33.33%
Totals Coverage Status
Change from base Build 8473301402: 52.8%
Covered Lines: 85
Relevant Lines: 161

💛 - Coveralls

@mdpiper
Copy link
Member Author

mdpiper commented Aug 17, 2024

Ah, fixed the coveralls issue.

@mdpiper mdpiper merged commit 3ef7911 into main Aug 17, 2024
14 checks passed
@mdpiper mdpiper deleted the mdpiper/de-lint branch August 17, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants