Merge pull request #226 from csoltenborn/#225_FixWorkingDirDefault

bugfix: WorkingDir returned placeholder if setting was empty (but not null)
csoltenborn · Jun 26, 2018 · 2c2cdcb · 2c2cdcb
2 parents 7b848ef + 79ea310
commit 2c2cdcb
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 7 deletions.
diff --git a/GoogleTestAdapter/Core.Tests/Settings/SettingsWrapperTests.cs b/GoogleTestAdapter/Core.Tests/Settings/SettingsWrapperTests.cs
@@ -362,6 +362,58 @@ public void GetWorkingDir__EnvVarPlaceholderIsReplaced()
             }
         }
 
+        [TestMethod]
+        [TestCategory(Unit)]
+        public void GetWorkingDirForExecution_null_ExecutableDirIsReturned()
+        {
+            MockXmlOptions.Setup(o => o.WorkingDir).Returns((string)null);
+
+            var result = TheOptions.GetWorkingDirForExecution(TestResources.Tests_DebugX86, "", 0);
+
+            var expectedDir = new FileInfo(TestResources.Tests_DebugX86).Directory?.FullName;
+            result.Should().NotBeNullOrEmpty();
+            result.Should().BeEquivalentTo(expectedDir);
+        }
+
+        [TestMethod]
+        [TestCategory(Unit)]
+        public void GetWorkingDirForExecution_EmptyString_ExecutableDirIsReturned()
+        {
+            MockXmlOptions.Setup(o => o.WorkingDir).Returns("");
+
+            var result = TheOptions.GetWorkingDirForExecution(TestResources.Tests_DebugX86, "", 0);
+
+            var expectedDir = new FileInfo(TestResources.Tests_DebugX86).Directory?.FullName;
+            result.Should().NotBeNullOrEmpty();
+            result.Should().BeEquivalentTo(expectedDir);
+        }
+
+        [TestMethod]
+        [TestCategory(Unit)]
+        public void GetWorkingDirForDiscovery_null_ExecutableDirIsReturned()
+        {
+            MockXmlOptions.Setup(o => o.WorkingDir).Returns((string) null);
+
+            var result = TheOptions.GetWorkingDirForDiscovery(TestResources.Tests_DebugX86);
+
+            var expectedDir = new FileInfo(TestResources.Tests_DebugX86).Directory?.FullName;
+            result.Should().NotBeNullOrEmpty();
+            result.Should().BeEquivalentTo(expectedDir);
+        }
+
+        [TestMethod]
+        [TestCategory(Unit)]
+        public void GetWorkingDirForDiscovery_EmptyString_ExecutableDirIsReturned()
+        {
+            MockXmlOptions.Setup(o => o.WorkingDir).Returns("");
+
+            var result = TheOptions.GetWorkingDirForDiscovery(TestResources.Tests_DebugX86);
+
+            var expectedDir = new FileInfo(TestResources.Tests_DebugX86).Directory?.FullName;
+            result.Should().NotBeNullOrEmpty();
+            result.Should().BeEquivalentTo(expectedDir);
+        }
+
         [TestMethod]
         [TestCategory(Unit)]
         public void GetUserParams__EnvVarPlaceholderIsReplaced()

diff --git a/GoogleTestAdapter/Core/Settings/SettingsWrapper.cs b/GoogleTestAdapter/Core/Settings/SettingsWrapper.cs
@@ -335,23 +335,21 @@ public virtual int TestDiscoveryTimeoutInSeconds {
             DescriptionOfThreadIdPlaceholder + DescriptionTestExecutionOnly + "\n" + 
             DescriptionOfEnvVarPlaceholders;
 
-        public virtual string WorkingDir => _currentSettings.WorkingDir ?? OptionWorkingDirDefaultValue;
+        public virtual string WorkingDir => string.IsNullOrWhiteSpace(_currentSettings.WorkingDir) 
+            ? OptionWorkingDirDefaultValue 
+            : _currentSettings.WorkingDir;
 
         public string GetWorkingDirForExecution(string executable, string testDirectory, int threadId)
         {
-            return string.IsNullOrWhiteSpace(WorkingDir) 
-                ? OptionWorkingDirDefaultValue 
-                : ReplaceEnvironmentVariables(
+            return ReplaceEnvironmentVariables(
                     ReplaceSolutionDirPlaceholder(
                         ReplaceExecutablePlaceholders(
                             ReplaceTestDirAndThreadIdPlaceholders(WorkingDir, testDirectory, threadId), executable)));
         }
 
         public string GetWorkingDirForDiscovery(string executable)
         {
-            return string.IsNullOrWhiteSpace(WorkingDir) 
-                ? new FileInfo(executable).DirectoryName 
-                : ReplaceEnvironmentVariables(
+            return ReplaceEnvironmentVariables(
                     ReplaceSolutionDirPlaceholder(
                         RemoveTestDirAndThreadIdPlaceholders(
                             ReplaceExecutablePlaceholders(WorkingDir, executable))));