Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Enhancement) Ignore particular lines #5

Open
HiEv opened this issue Dec 20, 2019 · 4 comments
Open

(Enhancement) Ignore particular lines #5

HiEv opened this issue Dec 20, 2019 · 4 comments

Comments

@HiEv
Copy link

HiEv commented Dec 20, 2019

Could you add an option to have this VSCode extension ignore particular lines? For example, any line that includes "/* csstree-ignore-line */".

I have some code in my CSS for older browsers (e.g. -webkit-margin-before:, -webkit-margin-after:, width: -webkit-fill-available, width: -moz-available, and width: fill-available), which are reported as errors, and I'd rather have an empty "Problems" window in VSCode. Giving me a way to have your extension not report those lines as errors would really be appreciated.

Thank you, and thank you for the VSCode extension. 😃

@HiEv HiEv changed the title (Feature request) Ignore particular lines (Enhancement) Ignore particular lines Dec 20, 2019
@timohofmeijer
Copy link

timohofmeijer commented Apr 29, 2020

I'd also like to be able to do this. In my case to silence a validator error when using font-display.

@font-face {
  font-display: swap;
}

see: csstree/csstree#108

@HarryAdney
Copy link

Any update on this?

@lahmatiy
Copy link
Member

Issue with font-display is not an issue anymore, since plugin validates at-rule's declarations based on a dictionary for at-rules now.

I believe that comments is not a good approach to disable validation.

Options we have:

  • Use stylelint + VS Code stylelint plugin + stylelint CSSTree plugin. In this case you may tweak syntax dictionary and use other options to fix warning. I see this approach as a better choice for now, since stylelint + CSSTree plugin may be used on CI as well.
  • Extend syntax dictionary in CSSTree (patch for mdn-data) or in mdn-data, and wait for merge/release and this plugin update. I may take some time, but will be helpful for others who use such properties (syntax dictionaries are incomplete currently), so that's good for a dev community.
  • Add some settings to this plugin. However, I'm not sure it will satisfy user's needs and looks a bit complicated for users.

@antefix-consulting
Copy link

The 'csstree-ignore-line' comment would be a great way to handle this. It's flexible, easy to understand and apply, and wouldn't require any configuration changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants