Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor _get_grid* functionality #146

Open
mexanick opened this issue Feb 6, 2025 · 0 comments
Open

Refactor _get_grid* functionality #146

mexanick opened this issue Feb 6, 2025 · 0 comments

Comments

@mexanick
Copy link

mexanick commented Feb 6, 2025

          Looks like this method has similar meaning to `get_grids()` of the other derived classes, or `get_grids_for_interpolation()` of the parent class, but has a different name. Consider a uniform name and an abstract method (or some sort of default implementation) in the base class.

Originally posted by @mexanick in #143 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant