Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable reading R0 data from ctapipe processor #148

Open
nietootein opened this issue Feb 12, 2025 · 1 comment
Open

Enable reading R0 data from ctapipe processor #148

nietootein opened this issue Feb 12, 2025 · 1 comment
Assignees
@jbuces
Labels
aitrigger enhancement

Comments

@nietootein
Copy link
Member

Reading from R0/R1 is currently missing and is needed for those projects that take waveforms as input.
@TjarkMiener
Copy link
Member

TjarkMiener commented Feb 12, 2025 •
edited
Loading

R1 is already implemented in the subclass DLWaveformReader. I'm suggesting to implement a new subclass (e.g. DLTriggerReader) that reads from R0 data and do the trigger patch selection as it was done in the previous version of dl1dh. @jbuces I'd explore if it would be possible to inherit from DLWaveformReader, so you have all the config settings from it.

@TjarkMiener TjarkMiener changed the title Enable reading R0/R1 data from ctapipe processor Enable reading R0 data from ctapipe processor Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbuces jbuces

Labels
aitrigger enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nietootein @TjarkMiener @jbuces