Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: qr code #108

Open
h0ethan04 opened this issue Mar 8, 2025 · 0 comments
Open

Bugfix: qr code #108

h0ethan04 opened this issue Mar 8, 2025 · 0 comments
Assignees
Labels

Comments

@h0ethan04
Copy link
Collaborator

Description

While the qr code functionality is complete, there are some oddities in its behaviors that we need to clean up.

READ ALL INSTRUCTIONS BEFORE STARTING

  • Note:
    • When working on the frontend, we want to work from making sure the site is responsive starting from a mobile device (this will make it easier when we modifying the styling for bigger screens)
    • When checking how the frontend looks on a mobile device through chrome's inspect element, be sure to select iPhone SE for test!!!
  • Heads up:
    • Feel free to utilize /client/src/components/playground/Playground.jsx to test out anything before putting it in their respective pages, or if there currently is no respective page

    • When prompted to log in, you can sign in with the account:

    • student:

    • teacher:

    • admin:

Instructions

  • qr code should be moved into Teacher view components; make sure it shows up in the Teacher class and Teacher event modals in the /src/components/bookings directory of our frontend
  • checking in for classes using the qr code leads to too many entries in the table; there are two new entries in the table instead of one. Eliminate the extra post request, and ensure that students can only check in for a "scheduled class" once.
  • event checkins make a post request, but since events are a single occurrence we can just change to a put request and modify the existing entry in the table. Additionally, similar to the classes, we also have the bug of multiple post requests being sent and excessive entries in the table.

Notes

Acceptance Criteria

  • Resolves all bugs without introducing new unintended behaviors
  • Matches hi-fi structure (you can ignore coloring for now)
  • qr code is properly placed into teacher view components and does not show up on the student side

Resources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants