Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

77 create class flow for teachers #93

Open
wants to merge 27 commits into
base: dev
Choose a base branch
from
Open

77 create class flow for teachers #93

wants to merge 27 commits into from
+3,627 −2,152

Conversation

aagrawal05
Copy link
Contributor

Description

Screenshots/Media

Issues

Closes #77

Priyansh4444 and others added 12 commits February 17, 2025 20:24
@Priyansh4444
merging with dev along with making a few changes
4120ce9
@Priyansh4444
Merge branch 'dev' into 77-create-class-flow-for-teachers
8d55607
@Priyansh4444
lazily implementing the modal, but combining current modal, automatic…
d749632 
…ally closing modal on posting,

getting the userID, and adding styliing to class to show data fetched
@Priyansh4444
removing the cancel and close button, they can press the x button to …
bbb6f03 
…cancel, and save as draft before closing if need be and an apt title for drafted / published
@Priyansh4444
changing what the button shows when it is a draft and linking classes…
23ac6bf 
… to the actual class
@Priyansh4444
sending down navigate rather than recreating a new one everytime
9e657cd
@Priyansh4444
adding a loading spinner just incase as well and cleaning up alot
f8c313b
@Priyansh4444
Create a class or a draft
cb0103b
@Priyansh4444
adding a way to close the modal properly
30fa2c0
@Priyansh4444
class confrimation
e344472
@aagrawal05
working shit
f7ea894
@aagrawal05
final
6fd8d56
@aagrawal05 aagrawal05 linked an issue Feb 20, 2025 that may be closed by this pull request
Create Class Flow for Teachers #77
Open
@aagrawal05
Copy link
Contributor Author

aagrawal05 commented Feb 20, 2025 •
edited by h0ethan04
Loading

@h0ethan04 @stevem-zhou

stevem-zhou and others added 14 commits February 21, 2025 22:47
@aagrawal05
Copy link
Contributor Author

aagrawal05 commented Mar 13, 2025 •
edited
Loading

@ethan-so @stevem-zhou ready for review

Remaining (minor) items:

  1. Move from playground to router (one line)
  2. Clarify behaviour scheduled-class post request after publishing (one line)
  3. Co-requisites router doesn't exist yet, complete after merge (one line, data + condition already setup)
  4. Two tabs for drafts -> one tab (trivial refactor to list both cards in one tab)
  5. Reload data locally with custom callback (a bit more involved but non-essential for future tasks)

Regarding the future student_view, this system should be easy to extend to include this functionality with it's modularity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevem-zhou stevem-zhou Awaiting requested review from stevem-zhou

@h0ethan04 h0ethan04 Awaiting requested review from h0ethan04

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Class Flow for Teachers
4 participants
@aagrawal05 @Priyansh4444 @stevem-zhou @h0ethan04