Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dependencies for VoteIT #71

Merged
merged 9 commits into from
Sep 14, 2020
Merged

update dependencies for VoteIT #71

merged 9 commits into from
Sep 14, 2020

Conversation

Deltaphish
Copy link

Rewrite dockerfile and package.json to use newer versions of dependencies for security and future stability.

@Deltaphish Deltaphish added the Wip Work in progress, do not merge label Mar 27, 2020
Portals
Portals reviewed Mar 27, 2020
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@Deltaphish Deltaphish marked this pull request as ready for review March 27, 2020 23:58
@Deltaphish Deltaphish changed the title WIP: update dependencies for VoteIT update dependencies for VoteIT Mar 27, 2020
@Deltaphish Deltaphish added dependencies Pull requests that update a dependency file security and removed Wip Work in progress, do not merge labels Mar 27, 2020
@Deltaphish Deltaphish linked an issue Mar 30, 2020 that may be closed by this pull request
Old dependencies crashing docker build + introducing possible security issues #70
Open
lindskogen
lindskogen approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@lindskogen lindskogen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Dr-Horv
Dr-Horv reviewed Apr 2, 2020
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@Deltaphish
Changed maintainer to digit
f20d0b3 
Changed MAINTAINER to LABEL since it is deprecated.
bark
bark reviewed Apr 3, 2020
View reviewed changes
Dockerfile Show resolved Hide resolved
bark
bark reviewed Apr 3, 2020
View reviewed changes
gulpfile.js Show resolved Hide resolved
@Portals Portals changed the base branch from master to online September 14, 2020 17:28
@Portals Portals merged commit 4bb15d4 into cthit:online Sep 14, 2020
@Portals
Copy link
Member

Portals commented Sep 14, 2020

Will continue working on online branch to give an example for how online voting could work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Portals Portals Portals left review comments

@Dr-Horv Dr-Horv Dr-Horv left review comments

@lindskogen lindskogen lindskogen approved these changes

@bark bark bark left review comments

@rosengrenen rosengrenen rosengrenen approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Old dependencies crashing docker build + introducing possible security issues
6 participants
@Deltaphish @Portals @bark @lindskogen @Dr-Horv @rosengrenen