You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In both cases, the value entry foo will be flagged as a readme file.
The same applies to the other Boolean file flags, i.e. configuration, documentation, license, ghost, missingOk, noreplace.
This is not intuitive. As a user, I would assume that false and true are different. I think false should be equivalent to ommitting the xml-element.
I stumbled over this while reviewing the code of de.dentrassi.rpm.builder.EntryDetails.apply: It does not make any difference whether the value of, say, EntryDetails.readme is set to Boolean.TRUE or Boolean.FALSE. The corresponing file flag will be set in both cases.
I am currently fixing #41 and I am uncertain whether I should do the same there.
The text was updated successfully, but these errors were encountered:
OliverMatz
added a commit
to Governikus/rpm-builder
that referenced
this issue
Sep 13, 2019
* New test EntryDetailsTest
* see #42
* EntryDetailsTest: verify return value of EntryDetails.apply(..)
* Allow to control verification flags.
* Requires modifications from eclipse/packager#6
* Fix for #41.
* upgrade org.eclipse.packager:packager-rpm to 0.16.0
* resolve merge conflict
* rename VerifyDetails.md5 to fileDigest, add javadoc
* add license header
* primitive boolean rather than Boolean,
* dadaistic javadoc to suppress warnings
Signed-off-by: Oliver Matz <[email protected]>
The following two entry declarations in the file pom.xml are equivalent:
In both cases, the value entry
foo
will be flagged as a readme file.The same applies to the other Boolean file flags, i.e. configuration, documentation, license, ghost, missingOk, noreplace.
This is not intuitive. As a user, I would assume that
false
andtrue
are different. I thinkfalse
should be equivalent to ommitting the xml-element.I stumbled over this while reviewing the code of
de.dentrassi.rpm.builder.EntryDetails.apply
: It does not make any difference whether the value of, say,EntryDetails.readme
is set toBoolean.TRUE
orBoolean.FALSE
. The corresponing file flag will be set in both cases.I am currently fixing #41 and I am uncertain whether I should do the same there.
The text was updated successfully, but these errors were encountered: