Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File flags readme etc can be set indifferently with either true or false #42

Open
OliverMatz opened this issue Sep 13, 2019 · 0 comments

Comments

@OliverMatz
Copy link
Contributor

The following two entry declarations in the file pom.xml are equivalent:

<entry>
     <name>/opt/foo</name>
     <file>foo</file>
     <readme>false</readme>
</entry>
<entry>
     <name>/opt/foo</name>
     <file>foo</file>
     <readme>true</readme>
</entry>

In both cases, the value entry foo will be flagged as a readme file.
The same applies to the other Boolean file flags, i.e. configuration, documentation, license, ghost, missingOk, noreplace.

This is not intuitive. As a user, I would assume that false and true are different. I think false should be equivalent to ommitting the xml-element.

I stumbled over this while reviewing the code of de.dentrassi.rpm.builder.EntryDetails.apply: It does not make any difference whether the value of, say, EntryDetails.readme is set to Boolean.TRUE or Boolean.FALSE. The corresponing file flag will be set in both cases.

I am currently fixing #41 and I am uncertain whether I should do the same there.

OliverMatz added a commit to Governikus/rpm-builder that referenced this issue Sep 13, 2019
see ctron#42

Signed-off-by: Oliver Matz <[email protected]>
ctron pushed a commit that referenced this issue Sep 18, 2019
* New test EntryDetailsTest
* see #42
* EntryDetailsTest: verify return value of EntryDetails.apply(..)
* Allow to control verification flags.
* Requires modifications from eclipse/packager#6
* Fix for #41.
* upgrade org.eclipse.packager:packager-rpm to 0.16.0
* resolve merge conflict
* rename VerifyDetails.md5 to fileDigest, add javadoc
* add license header
* primitive boolean rather than Boolean,
* dadaistic javadoc to suppress warnings

Signed-off-by: Oliver Matz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant