Skip to content

Commit 1e482cf

Browse files
committed
Fix some parameters for nav and right
1 parent d92e6fb commit 1e482cf

File tree

8 files changed

+28
-14
lines changed

8 files changed

+28
-14
lines changed

.idea/gradle.xml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/src/main/java/com/cornellappdev/scoop/ui/components/general/NavHeader.kt

+6-2
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,15 @@ import androidx.navigation.NavController
2020
import com.cornellappdev.scoop.R
2121
import com.cornellappdev.scoop.ui.theme.Green
2222
import com.google.accompanist.pager.PagerState
23+
import kotlinx.coroutines.Dispatchers
2324
import kotlinx.coroutines.launch
25+
import kotlinx.coroutines.withContext
2426

2527
@OptIn(ExperimentalMaterialApi::class, com.google.accompanist.pager.ExperimentalPagerApi::class)
2628
@Composable
2729
fun NavHeader(
2830
title: String,
29-
pagerState: PagerState,
31+
backFunction: suspend () -> Unit,
3032
hasBackArrow: Boolean = false,
3133
) {
3234
val scope = rememberCoroutineScope()
@@ -45,7 +47,9 @@ fun NavHeader(
4547
Button(
4648
onClick = {
4749
scope.launch {
48-
pagerState.animateScrollToPage(pagerState.currentPage - 1)
50+
withContext(Dispatchers.IO){
51+
backFunction()
52+
}
4953
}
5054
},
5155
colors = ButtonDefaults.buttonColors(backgroundColor = Color.White),

app/src/main/java/com/cornellappdev/scoop/ui/components/general/RightArrow.kt

+9-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.cornellappdev.scoop.components
22

3+
import android.util.Log
34
import androidx.compose.foundation.layout.Box
45
import androidx.compose.foundation.layout.fillMaxSize
56
import androidx.compose.foundation.layout.height
@@ -19,12 +20,15 @@ import com.cornellappdev.scoop.ui.theme.DarkGray
1920
import com.cornellappdev.scoop.ui.theme.Gray
2021
import com.cornellappdev.scoop.ui.theme.Green
2122
import com.google.accompanist.pager.PagerState
23+
import kotlinx.coroutines.CoroutineScope
24+
import kotlinx.coroutines.Dispatchers
2225
import kotlinx.coroutines.launch
26+
import kotlinx.coroutines.withContext
2327

2428
@OptIn(ExperimentalMaterialApi::class, com.google.accompanist.pager.ExperimentalPagerApi::class)
2529
@Composable
2630
fun RightArrow(
27-
pagerState: PagerState,
31+
nextFunction: suspend () -> Unit,
2832
isComplete : Boolean = false,
2933
) {
3034
val scope = rememberCoroutineScope()
@@ -37,8 +41,11 @@ fun RightArrow(
3741
enabled = isComplete,
3842
backgroundColor = if (isComplete) Green else Gray,
3943
onClick = {
44+
Log.d("PAGERSTATE", "button Clicked")
4045
scope.launch {
41-
pagerState.animateScrollToPage(pagerState.currentPage + 1)
46+
withContext(Dispatchers.IO) {
47+
nextFunction()
48+
}
4249
}
4350
}
4451
) {

app/src/main/java/com/cornellappdev/scoop/ui/onboarding/OnboardingProfile.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ fun OnboardingProfile(pagerState: PagerState) {
4242
Modifier.background(Color.White)
4343
) {
4444

45-
NavHeader(pagerState = pagerState, title = "Profile", hasBackArrow = true)
45+
NavHeader(backFunction = suspend { pagerState.animateScrollToPage(pagerState.currentPage - 1) }, title = "Profile", hasBackArrow = false)
4646

4747
Column(
4848
modifier = Modifier

app/src/main/java/com/cornellappdev/scoop/ui/onboarding/OnboardingView2.kt

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.cornellappdev.scoop.ui.onboarding
22

3+
import android.util.Log
34
import androidx.compose.foundation.background
45
import androidx.compose.foundation.layout.*
56
import androidx.compose.runtime.Composable
@@ -31,7 +32,7 @@ fun OnboardingView2(pagerState: PagerState) {
3132
Column(
3233
Modifier.background(Color.White)
3334
) {
34-
NavHeader(pagerState = pagerState, title = "About You")
35+
NavHeader(backFunction = suspend { pagerState.animateScrollToPage(pagerState.currentPage - 1) }, title = "Profile", hasBackArrow = false)
3536

3637
Column(
3738
modifier = Modifier
@@ -101,7 +102,8 @@ fun OnboardingView2(pagerState: PagerState) {
101102
horizontalArrangement = Arrangement.SpaceBetween
102103
) {
103104
BackArrow(pagerState)
104-
RightArrow(pagerState, isComplete)
105+
RightArrow( suspend { pagerState.animateScrollToPage(pagerState.currentPage + 1)
106+
}, isComplete)
105107
}
106108
Spacer(modifier = Modifier.height(40.dp))
107109
Row(

app/src/main/java/com/cornellappdev/scoop/ui/onboarding/OnboardingView3.kt

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ fun OnboardingView3(pagerState: PagerState) {
2929
Column(
3030
Modifier.background(Color.White)
3131
) {
32-
NavHeader(pagerState = pagerState, title = "About You")
32+
NavHeader(backFunction = suspend { pagerState.animateScrollToPage(pagerState.currentPage - 1) }, title = "Profile", hasBackArrow = false)
3333

3434
Column(
3535
modifier = Modifier
@@ -59,7 +59,7 @@ fun OnboardingView3(pagerState: PagerState) {
5959
horizontalArrangement = Arrangement.SpaceBetween
6060
) {
6161
BackArrow(pagerState)
62-
RightArrow(pagerState, true)
62+
RightArrow(suspend { pagerState.animateScrollToPage(pagerState.currentPage + 1) }, true)
6363
}
6464
Spacer(modifier = Modifier.height(40.dp))
6565
Row(

app/src/main/java/com/cornellappdev/scoop/ui/onboarding/OnboardingView4.kt

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ fun OnboardingView4(
3131
Modifier.background(Color.White)
3232
) {
3333

34-
NavHeader(pagerState = pagerState, title = "During Roadtrips")
34+
NavHeader(backFunction = suspend { pagerState.animateScrollToPage(pagerState.currentPage - 1) }, title = "Profile", hasBackArrow = false)
3535

3636
Column(
3737
modifier = Modifier
@@ -79,7 +79,7 @@ fun OnboardingView4(
7979
horizontalArrangement = Arrangement.SpaceBetween
8080
) {
8181
BackArrow(pagerState)
82-
RightArrow(pagerState, true)
82+
RightArrow(suspend { pagerState.animateScrollToPage(pagerState.currentPage + 1) }, true)
8383
}
8484
Spacer(modifier = Modifier.height(40.dp))
8585
Row(

app/src/main/java/com/cornellappdev/scoop/ui/onboarding/OnboardingView5.kt

+3-3
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ fun OnboardingView5(pagerState: PagerState) {
2828

2929
Column(
3030
Modifier.background(Color.White)
31-
) {
32-
NavHeader(pagerState = pagerState, title = "Favorites")
31+
) { NavHeader(backFunction = suspend { pagerState.animateScrollToPage(pagerState.currentPage - 1) }, title = "Profile", hasBackArrow = false)
3332

3433
Column(
3534
modifier = Modifier
@@ -87,7 +86,8 @@ fun OnboardingView5(pagerState: PagerState) {
8786
horizontalArrangement = Arrangement.SpaceBetween
8887
) {
8988
BackArrow(pagerState)
90-
RightArrow(pagerState, isComplete)
89+
RightArrow( nextFunction = suspend { pagerState.animateScrollToPage(pagerState.currentPage + 1)
90+
}, isComplete)
9191
}
9292
Spacer(modifier = Modifier.height(40.dp))
9393
Row(

0 commit comments

Comments
 (0)