You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we barely test that xarray objects wrapping cubed arrays actually compute correctly when called upon. Instead we are basically assuming that:
(a) cubed supporting the array API
(b) xarray supposedly correctly calling the array API
(c) chunk-aware functions being re-routed through the ChunkManagerEntrypoint
is together enough for most operations to "just work".
In practice that won't be enough to ensure successful computation on cubed arrays (see list of known problems in the readme), and a more comprehensive testing approach is needed.
The long-term best way to fully test this integration would be to finish creating the framework suggested in pydata/xarray#6894, then import and use that in this repository. Unfortunately there is still a fair bit of work to get to that point (especially finishing pydata/xarray#6908.
Yeah I think a place to start would just to have at least one test per method in the ChunkManager. I.e. chunk, rechunk, reduction, apply_ufunc, store, to_zarr, scan? Etc.
Currently we barely test that xarray objects wrapping cubed arrays actually compute correctly when called upon. Instead we are basically assuming that:
(a) cubed supporting the array API
(b) xarray supposedly correctly calling the array API
(c) chunk-aware functions being re-routed through the
ChunkManagerEntrypoint
is together enough for most operations to "just work".
In practice that won't be enough to ensure successful computation on cubed arrays (see list of known problems in the readme), and a more comprehensive testing approach is needed.
The long-term best way to fully test this integration would be to finish creating the framework suggested in pydata/xarray#6894, then import and use that in this repository. Unfortunately there is still a fair bit of work to get to that point (especially finishing pydata/xarray#6908.
cc @tomwhite
The text was updated successfully, but these errors were encountered: