New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Modal deprecation of `f.call(...)` #320

Merged

tomwhite merged 2 commits into main from fix-modal-call-deprecation

Nov 10, 2023

Member

tomwhite commented Nov 10, 2023

Failure was (e.g. https://github.com/tomwhite/cubed/actions/runs/6820474263):

FAILED cubed/tests/runtime/test_modal_async.py::test_stragglers[timing_map0-10-2-expected_invocation_counts_overrides0] - FileNotFoundError: ['cubed-unittest/map_unordered']
FAILED cubed/tests/runtime/test_modal_async.py::test_batch - modal.exception.DeprecationError: Deprecated on 2023-08-16: `f.call(...)` is deprecated. It has been renamed to `f.remote(...)`

tomwhite added 2 commits

November 10, 2023 17:19


          Fix Modal deprecation of f.call(...)

65ec647


          Allow redefinition for mypy

a47e84c

tomwhite merged commit 19af1dd into main

7 checks passed

tomwhite deleted the fix-modal-call-deprecation branch

November 10, 2023 17:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet