Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Modal unit tests following change in #382 #387

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix Modal unit tests following change in #382 #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions cubed/tests/runtime/test_modal_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,20 +35,22 @@
@stub.function(
image=image, secret=modal.Secret.from_name("my-aws-secret"), retries=2, timeout=10
)
def deterministic_failure_modal(i, path=None, timing_map=None):
return deterministic_failure(path, timing_map, i)
def deterministic_failure_modal(i, path=None, timing_map=None, *, name=None):
return deterministic_failure(path, timing_map, i, name=name)


@stub.function(image=image, secret=modal.Secret.from_name("my-aws-secret"), timeout=10)
def deterministic_failure_modal_no_retries(i, path=None, timing_map=None):
return deterministic_failure(path, timing_map, i)
def deterministic_failure_modal_no_retries(i, path=None, timing_map=None, *, name=None):
return deterministic_failure(path, timing_map, i, name=name)


@stub.function(
image=image, secret=modal.Secret.from_name("my-aws-secret"), retries=2, timeout=300
)
def deterministic_failure_modal_long_timeout(i, path=None, timing_map=None):
return deterministic_failure(path, timing_map, i)
def deterministic_failure_modal_long_timeout(
i, path=None, timing_map=None, *, name=None
):
return deterministic_failure(path, timing_map, i, name=name)


async def run_test(app_function, input, use_backups=False, batch_size=None, **kwargs):
Expand Down
Loading