Track source array names in PrimitiveOperation #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment ordering The bug was due to a mismatch between the order of the input source arrays in the DAG and the function argument order for the operation. Since the DAG order is not stable, the operation now records the names of the input source arrays in the source_array_names variable.
tomwhite
force-pushed
the
track-source-array-names
branch
from
dba223a to
5606da8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with argument ordering found in #412 (comment).
The bug was due to a mismatch between the order of the input source arrays in the DAG and the function argument order for the operation. Since the DAG order is not stable, the operation now records the names of the input source arrays in the source_array_names variable.