Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORDIC in Filament #330

Closed
gabizon103 opened this issue Sep 19, 2023 · 6 comments
Closed

CORDIC in Filament #330

gabizon103 opened this issue Sep 19, 2023 · 6 comments
Labels
S: needs triage Status: Needs some more thinking before being actionable

Comments

@gabizon103
Copy link
Collaborator

We want to implement more designs in Filament (ideas listed in #124), so I'll take a shot at CORDIC. Will list some resources/other implementations here

@rachitnigam
Copy link
Member

Extremely hype! I think it would be cool to spend some time thinking what kinds of design trade-offs we'd like to expose using parameters and what capabilities they can express. Once we have that, let's write up a proposal for implementation and get started!

@gabizon103
Copy link
Collaborator Author

Very true, that is a good idea. I think I'll start with writing a simple unparameterized version of it to get an idea of what makes sense to expose/parameterize. I can write up a proposal after that. Does that sound good?

@rachitnigam
Copy link
Member

Sure! The pre-reading suggestion was because it might be good to understand if there are any opportunities for parameterization in the design or not. If CORDIC doesn't have any opportunities, then we might prefer something else for the sake of more interesting exploration.

@gabizon103
Copy link
Collaborator Author

Ah, good point. I think it would be cool to do something that could show off existential parameters - I'll see if they can be applied here

@rachitnigam rachitnigam added the S: needs triage Status: Needs some more thinking before being actionable label Sep 22, 2023
@rachitnigam
Copy link
Member

@gabizon103 are you working on #332 instead of this? If so, let's close this issue for now

@rachitnigam
Copy link
Member

Okay, closing this for now but @gabizon103 feel free to reopen if you end up working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: needs triage Status: Needs some more thinking before being actionable
Projects
None yet
Development

No branches or pull requests

2 participants