Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 Validation: Image record page has Back to Search when no search was initiated #543

Open
elrayle opened this issue Apr 27, 2022 · 5 comments
Assignees
Labels
bug immediate Upgrade Issues that only occur in the branch for upgrading Spotlight

Comments

@elrayle
Copy link
Contributor

elrayle commented Apr 27, 2022

Reported by Craig Main in 2021-08-20 email...

When selecting an image, the Image record page has Back to Search when no search was initiated.

Expected (from 2.x Spotlight)

Page: https://exhibits.library.cornell.edu/bluest-eye/catalog/81-4550

image

Actual (from 3.x Spotlight)

Page: https://exhibits-prod-1.library.cornell.edu/bluest-eye/catalog/81-4550

image

@elrayle elrayle added bug Upgrade Issues that only occur in the branch for upgrading Spotlight labels Apr 27, 2022
@elrayle elrayle changed the title 3.0 Validation: 3.0 Validation: Image record page has Back to Search when no search was initiated Apr 27, 2022
@mhk33
Copy link
Collaborator

mhk33 commented Apr 28, 2022

Here is an example with the Start Over button.
https://exhibits-prod-1.library.cornell.edu/bluest-eye/catalog/81-4891

I'm not sure what to do in this case. I would be tempted to remove the Start over and Back to search buttons entirely, but I guess it would be possible for someone to display items in the browse or search view, where it would make sense to have them.

@elrayle
Copy link
Contributor Author

elrayle commented May 5, 2022

I traced the display to Blacklight /app/components/blacklight/constraints_component.html.erb and setting of the @start_over_component in constraints_component.rb. I have not found a configuration to control this. I asked about this in Slack.

@elrayle
Copy link
Contributor Author

elrayle commented May 5, 2022

Components, at least for this, aren't being used. The buttons are being rendered in Blacklight at app/views/catalog/show.html.erb based on the fact that there is a search session. The pagination doesn't show based on an override happening in Spotlight. I'm looking to see if a similar override can happen for the buttons.

@elrayle
Copy link
Contributor Author

elrayle commented May 5, 2022

Contributed a fix for this in Spotlight PR projectblacklight/spotlight#2815

@mhk33
Copy link
Collaborator

mhk33 commented Mar 23, 2023

See more comments here: https://culibrary.atlassian.net/browse/LP-172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug immediate Upgrade Issues that only occur in the branch for upgrading Spotlight
Projects
None yet
Development

No branches or pull requests

4 participants