Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dials objects #20

Open
topepo opened this issue Jul 31, 2020 · 1 comment
Open

dials objects #20

topepo opened this issue Jul 31, 2020 · 1 comment

Comments

@topepo
Copy link
Collaborator

topepo commented Jul 31, 2020

You convert mtry to a proportion. You might consider changing:

parsnip::set_model_arg(
  model = "boost_tree",
  eng = "catboost",
  parsnip = "mtry",
  original = "rsm",
  func = list(pkg = "dials", fun = "mtry"),
  has_submodel = FALSE
)

to

parsnip::set_model_arg(
  model = "boost_tree",
  eng = "catboost",
  parsnip = "mtry",
  original = "rsm",
  func = list(pkg = "dials", fun = "mtry_prop"),
  has_submodel = FALSE
)

once I I transfer it over to dials from rules where it currently resides.

There are a lot of parameters to this engine (and for lightGBM). If you make a list of the ones that other might tune, we can add dials parameters to make their optimization easier.

@siegfried
Copy link
Contributor

I just noted that num_leaves is missing, which is important according to LightGBM's docs. Should it be added to dials? Or parsnip?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants