Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No remote data after core update >2024.11.3 -> Identify the problem #332

Closed
KingofCurrywurst opened this issue Dec 14, 2024 · 3 comments
Closed

Comments

@KingofCurrywurst
Copy link

Findings on Issue #330

The problem starts with ha-core update > 2024.11.3. Up to this version, the integration of "remote_homeassistant" worked without any problems.
The problem is definitely in the interaction between ha-core <> "remote_homeassistant" because I tested 4.3/4.4/4.5, but as soon as core is higher than 2024.11.3, "remote_homeassistant" stops.

My working settings up to core > 2024.12:

Remote HA OK_x

I suspect my setting "Port=0" is no longer supported with the new ha-core 2024.12.x. I don't need a port because port forwarding is done directly with cloudflare.

Would it be possible to integrate this "no port" function into this very helpful application so that I can also update the ha-core.

Thanks

@lukas-hetzenecker
Copy link
Member

Hello,

as this is a TCP/HTTPS connection, you always require a port. If you just use a default HTTPS connection, have you tried using 443 as port?
I do not know why Port=0 was ever supported, or what the default value for that should have been. IMHO this should never have worked :)

@lukas-hetzenecker
Copy link
Member

I got curious and looked up what changed that resulted in a different behavior

The URL handling in aiohttp was performed by aio-libs/yarl
Recent homeassistant releases include an updated version of that library.
1.17.2 includes the following change:

Fixed a bug causing :attr:~yarl.URL.port to return the default port when the given port was zero
-- by :user:gmacon.

Related issues and pull requests on GitHub:
aio-libs/yarl#1413.

So port=0 used to use a "default" port (443 for secure connections).
This apparently has been a bug as "it incorrectly used the fallback value when the given value was zero. This fixes the bug, returning the given value even when it is zero".

Summarized, please use 443 directly as port, the old behavior of being able to specify "0" has just been a bug.

@KingofCurrywurst
Copy link
Author

Hello Lukas,

Thank you for your effort, unfortunately this was a trap I fell into.
Using your instructions I changed the port to 443 so that it would work immediately, even with the newer HA core version.

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants