Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing SDK task.upload_data() to accept resources of the Path type #9114

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Fixing SDK task.upload_data() to accept resources of the Path type #9114

merged 5 commits into from
Feb 21, 2025
+10 −5

Conversation

RavinduWeerakoon
Copy link
Contributor

@RavinduWeerakoon RavinduWeerakoon commented Feb 17, 2025 •
edited
Loading

Motivation and context

Closes #9072

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@SpecLad
Copy link
Contributor

SpecLad commented Feb 19, 2025

Please add a changelog fragment (see the note at the top of CHANGELOG.md).

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.83%. Comparing base (397a915) to head (70ca3ca).
Report is 5 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #9114      +/-   ##
===========================================
- Coverage    73.97%   73.83%   -0.14%     
===========================================
  Files          430      431       +1     
  Lines        44631    44806     +175     
  Branches      3892     3892              
===========================================
+ Hits         33017    33084      +67     
- Misses       11614    11722     +108
Components Coverage Δ
cvat-ui 77.53% <ø> (+0.02%) ⬆️
cvat-server 70.80% <25.00%> (-0.26%) ⬇️

@SpecLad SpecLad merged commit cb7306b into cvat-ai:develop Feb 21, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpecLad SpecLad SpecLad approved these changes

@nmanovic nmanovic Awaiting requested review from nmanovic nmanovic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK task.upload_data() cannot be used with resources of the Path type
3 participants
@RavinduWeerakoon @SpecLad @codecov-commenter