Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lack of automated testing #33

Open
Remi-Gau opened this issue Feb 23, 2022 · 4 comments
Open

lack of automated testing #33

Remi-Gau opened this issue Feb 23, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@Remi-Gau
Copy link
Contributor

One of my concern regarding using GLMsingle is the lask of either unit or system test which creates an uncertainty whether the toolbox is giving expected results.

Tests can usually be easily implemented with external toolbox (moxunit for matlab) or packages (pytest for python).

Automating those tests (through github actions for example) can usually also prevent regression (breaking old feature A when implementing new feature B or fixing bug C).

If there is some interest I could help with setting some of these up.

@Remi-Gau
Copy link
Contributor Author

To be fair, GLMsingle is not unique in its lack of testing but it does not mean we can't try to raise the bar.

@kendrickkay
Copy link
Member

Yes, thanks for the nudge. We should make our way towards this. Let me confer with @iancharest.

@kendrickkay
Copy link
Member

Remi, Ian and I have been working through the issues/bugs/etc. on the repo. Currently, we have run the MATLAB and Python implementations on a small test dataset, and can confirm that the two implementations give (nearly) identical results....

In terms of the larger issue of automated unit testing, we think the code is in a good state to pursue that. If you feel motivated to work on this, we are happy to review/discuss and would be grateful for such efforts. Let us know if you want to discuss.

@Remi-Gau
Copy link
Contributor Author

Yup happy to give suggestions and maybe help set some foundations if you are interested. Feel free to ping me at remi dot gau at uclouvain dot be

@kendrickkay kendrickkay added the enhancement New feature or request label Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants