Nginx port and environment options #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating an nginx.env next to the cyber-dojo script will cause its contents to be read by Docker Compose, setting the provided environment variables inside the container.
|
I wasn't sure where to document the nginx.env file. The grafana.env file isn't documented, but as noted in cyber-dojo-retired/grafana#1, it's still WIP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #9, this provides a
--portoption for cyber-dojo, as well as support for an nginx.env file similar to the existing grafana.env.The target use-case is to expose cyber-dojo running on a shared machine via https://github.com/jwilder/nginx-proxy. This proxy will publish any exposed port using name-based virtual hosting, according to a
VIRTUAL_HOSTenvironment variable set in the container.