Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Publsh to nuget.org #85

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

WIP: Publsh to nuget.org #85

wants to merge 2 commits into from

Conversation

szh
Copy link
Contributor

@szh szh commented Mar 3, 2023

Desired Outcome

Add a build step to publish the .NET SDK to NuGet.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In
particular, consider:

  • What's changed? Why were these changes made?
  • How should the reviewer approach this PR, especially if manual tests are required?
  • Are there relevant screenshots you can add to the PR description?

Connected Issue/Story

CyberArk internal issue ID: ONYX-18165

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@szh szh self-assigned this Mar 3, 2023
@jtuttle
Copy link
Member

jtuttle commented Mar 3, 2023

@LukaszStrz FYI. Not sure if Synchronizer has gotten super involved in this repo yet, but we had a Focus Friday project to push to NuGet that Shlomo picked up.

@szh
Copy link
Contributor Author

szh commented Mar 3, 2023

Currently the thing holding this up is that there's already a version published on Nuget by a third party. @ismarc is going to work on contacting Microsoft to take ownership of the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants