Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix composer.json for PHP 8 #2

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Fix composer.json for PHP 8 #2

merged 6 commits into from
Mar 27, 2024

Conversation

zonky2
Copy link

@zonky2 zonky2 commented Mar 23, 2024

No description provided.

@zonky2 zonky2 deleted the branch cyberspectrum:fix/phpcq-2 March 25, 2024 18:02
@zonky2 zonky2 closed this Mar 25, 2024
@zonky2 zonky2 deleted the fix/phpcq-2 branch March 25, 2024 18:02
@zonky2 zonky2 restored the fix/phpcq-2 branch March 25, 2024 18:07
@discordier discordier reopened this Mar 25, 2024
discordier
discordier approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@discordier discordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Makes the build run again and allows installation.

Issues have to be fixed in main branch.

@discordier discordier merged commit d57243c into cyberspectrum:fix/phpcq-2 Mar 27, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discordier discordier discordier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zonky2 @discordier