-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default party & instance. #9
Comments
I can't implement this without fixing #10 and even then, I'm not entirely sure how to address this issue. |
Hmm... Do you really need to fix 10?. Let me put it this way:
What could happen instead is, welcome to default party [worldname](or something configurable) -> this would always be instance number 0 To make it even better, custom parties should always start on the next numbered instance (1) - and that could work as it does now. The benefit is really this would allow easy open access for a playerbase to an instanced world without learning or being hindered by party system. For those that start a custom party, it would still be the same "private" instance. You could do this without fixing #10 I'm sure, but it would be even better if you did. |
I get it now, nice idea. Have an optional default party per portal. If the player is not in a party. Rest of code continues to function as is. I don't see the benefit of reserving instance-0 for this, just use the existing logic for creating instances for parties if they do not already have one. Instance creation is relatively cheap. You're right does not depend on #10, thanks for expanding on the idea. |
Exactly! Although I can think of several good reasons to reserve instance 0 for that. 1) it gets predictable, 2) makes it muuuuch simpler for other plugins, scripts and whatnots to know which is the default instance - incredibly helpful for people like me :). 3) It's just more future-proof - you never know what someone (or you) is gonna think about next. Predictability and separation is good that way. It will give the choice to admins/players to do "open" instance or "private" instance. Open instances get a few more options for tweaking. I'm glad you like the idea, and thanks a bunch for your hard work! |
Fixed, will be in the 1.7 release. If you still want the default parties instance to always be named "world-0" please create a separate ticket. |
Default party instance on instance 0 - or configurable (if no party is chosen before, this is automatic - or just defaults to worldname). Easier "open" instances to join for anyone - no need to manually join a party.
The text was updated successfully, but these errors were encountered: