Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying revision history limit via annotation #105

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Hsn723
Copy link
Member

@Hsn723 Hsn723 commented Jul 9, 2024

The previous change introduced in #104 lacked documentation, and I've added support for specifying .spec.revisionHistoryLimit via the cert-manager.io/revision-history-limit annotation, aligning with expectations users familiar with cert-manager would have.

@tkna tkna requested a review from terassyi July 11, 2024 05:11
Copy link
Contributor

@terassyi terassyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkna tkna merged commit 6df66e9 into cybozu-go:main Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants