Add support for using delegated domains for DNS-01 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not desirable for cert-manager to be able to write to the root DNS zone for the sole purpose of DNS-01 validation. As such, in some environments cert-manager is expected to write to a dedicated sub-zone that exists only for DNS-01.
This PR allows contour-plus to accomodate such environments, by writing the CNAME delegation record pointing to the delegated domain when a delegated domain is specified by the contour-plus administrators via command-line flags, or by tenants via a newly defined
contour-plus.cybozu.com/delegated-domainannotation when permitted to do so. This way, anIssuerorClusterIssuerthat hascnameStrategy: Followenabled can perform DCV without writing to the root DNS zone.