Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8: Turn on B038 #5931

Closed
wxtim opened this issue Jan 17, 2024 · 2 comments · Fixed by #6022
Closed

Flake8: Turn on B038 #5931

wxtim opened this issue Jan 17, 2024 · 2 comments · Fixed by #6022
Assignees
Labels

Comments

@wxtim
Copy link
Member

wxtim commented Jan 17, 2024

(Requires closure of PyCQA/flake8-bugbear#451)

#5925 Turned of Flake8-Bugbear B038 because it was causing failures. We should fix these failures/decide that they are OK and remove the exception from tox.ini.

  • The two cases in async_util are probably legitimate exceptions to the rule, parly because they are while loops using the modification to empty an object.
  • The one in broadcast_report is also using a while loop, but might not need to: It's not a quick fix though - it's 9 YO code and as far as I can see has no unit tests. IMO needs a suite of unit tests existing behaviour before changing. Not a quick win.
  • The one is in network/scan.py and option_parsers.py are the result of the bug recorded at B038 false positive in 24.1.15 + 24.1.16 PyCQA/flake8-bugbear#451.
@wxtim wxtim added the small label Jan 17, 2024
@MetRonnie
Copy link
Member

https://github.com/PyCQA/flake8-bugbear/releases/tag/24.1.17

@MetRonnie
Copy link
Member

MetRonnie commented Feb 7, 2024

B038 has been changed to an optional "opinionated" warning B909 - PyCQA/flake8-bugbear#456

@MetRonnie MetRonnie self-assigned this Mar 14, 2024
@MetRonnie MetRonnie linked a pull request Mar 14, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants