Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill foreground event handlers on timeout #6639

Open
wants to merge 2 commits into
base: 8.4.x
Choose a base branch
from

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Feb 27, 2025

Close #6615

Shutdown handlers aren't run via the subprocess pool, which gets closed on shutdown, so they weren't subject to the process pool timeout. This PR imposes
the timeout on them anyway, outside of the pool.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@hjoliver hjoliver added the bug Something is wrong :( label Feb 27, 2025
@hjoliver hjoliver added this to the 8.4.x milestone Feb 27, 2025
@hjoliver hjoliver self-assigned this Feb 27, 2025
@hjoliver hjoliver force-pushed the foreground-handler-timeout branch from 15736e3 to 4beafcd Compare February 27, 2025 04:02
@hjoliver
Copy link
Member Author

Result, using the example from the issue:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant