Fix undefined behaviour #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents compiler warnings and segfaults when compiled with recent GCC.
processevent() expects this. This prevents the game from hanging on input when compiled with recent Clang.
ljn0099
pushed a commit
to ljn0099/ASCIIpOrtal
that referenced
this pull request
Dec 18, 2022
|
@zorun, maybe you could merge? In newer GCC non-void functions needs return |
|
Since this repository isn't getting updated (last update was 5 years ago), whoever wants this pull should just fork and merge the pull themselves, or directly use the repo that the pull is on (https://github.com/DelilahHoare/ASCIIpOrtal/tree/master). After all, that's why we have open-source. If a maintainer is done with a project or takes a break, the community can continue the project without their intervention. Everyone gets what they want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23.