Skip to content

Commit

Permalink
NEWS and CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
krlmlr committed Sep 30, 2021
1 parent 5974323 commit 80b484f
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 52 deletions.
55 changes: 13 additions & 42 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,56 +2,27 @@

# dm 0.2.4

- Same as previous version.


# dm 0.2.3.9007

- `sql_schema_list()` supports `pool::Pool` objects (#633, @brancengregory).
- Fix `dm_zoom_to()` for an empty table (#626, @moodymudskipper).


# dm 0.2.3.9006
## Features

- Better error message for `dm_rows_update()` and related functions for dm objects with tables without primary key (#592).
- `rows_insert()`, `rows_update()` and `rows_delete()` gain `returning` argument. In combination with `in_place = TRUE` this argument makes the newly inserted rows accessible via `get_returning_rows()` after the operation completes (#593, @mgirlich).
- Implement `rows_patch()` for DBI connections (#610, @mgirlich).
- Use `NO ACTION` instead of `CASCADE` in foreign key constraints to permit self-references.
- `dm_from_src()` supports `pool::Pool` objects (#599, @moodymudskipper).


# dm 0.2.3.9005

- Suggest manually quoting the returning argument (#627).
- `glimpse()` is implemented for dm objects (#605).
- Better error message for `dm_rows_update()` and related functions for dm objects with tables without primary key (#592).
- `glimpse()` is implemented for `dm` objects (#605).
- Support DuckDB in `rows_insert()`, `rows_update()` and `rows_delete()` (#617, @mgirlich).
- Implement `rows_patch()` for DBI connections (#610, @mgirlich).
- Use `check_suggested()` everywhere (#572, @moodymudskipper).


# dm 0.2.3.9004

- Establish compatibility with vctrs > 0.3.8.
- Establish compatibility with rlang > 0.4.11 (#613).


# dm 0.2.3.9003

- `rows_insert()`, `rows_update()` and `rows_delete()` gain `returning` argument. In combination with `in_place = TRUE` this argument makes the newly inserted rows accessible via `get_returning_rows()` after the operation completes (#593, @mgirlich).


# dm 0.2.3.9002
## Bug fixes

- Update tests for pillar 1.6.2.
- Add CI run for validating all new `dm` objects (#597).
- Fix `dm_zoom_to()` for `dm` objects with an empty table (#626, @moodymudskipper).
- Avoid generating invalid `dm` objects in some corner cases (#596).

## Internal

# dm 0.2.3.9001

- Use `NO ACTION` instead of `CASCADE` in foreign key constraints to permit self-references.


# dm 0.2.3.9000

- Same as previous version.
- `sql_schema_list()` supports `pool::Pool` objects (#633, @brancengregory).
- Establish compatibility with pillar 1.6.2, vctrs > 0.3.8 and rlang > 0.4.11 (#613).
- Use `check_suggested()` everywhere (#572, @moodymudskipper).
- Add CI run for validating all new `dm` objects (#597).


# dm 0.2.3
Expand Down
14 changes: 4 additions & 10 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,15 @@ dm 0.2.4

## Cran Repository Policy

- [ ] Reviewed CRP last edited 2021-09-25.

See changes at https://github.com/eddelbuettel/crp/compare/master@%7B2021-04-25%7D...master@%7B2021-09-25%7D
- [x] Reviewed CRP last edited 2021-09-25.

## R CMD check results

- [x] Checked locally, R 4.1.1
- [ ] Checked on CI system, R 4.1.1
- [ ] Checked on win-builder, R devel

Check the boxes above after successful execution and remove this line. Then run `fledge::release()`.
- [x] Checked on CI system, R 4.1.1
- [x] Checked on win-builder, R devel

## Current CRAN check results

- [x] Checked on 2021-09-29, problems found: https://cran.r-project.org/web/checks/check_results_dm.html
- [ ] ERROR: r-patched-linux-x86_64

Check results at: https://cran.r-project.org/web/checks/check_results_dm.html
- [x] ERROR: r-patched-linux-x86_64: False positive

0 comments on commit 80b484f

Please sign in to comment.