Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Large files failing when trying to return JSONObject #25

Open
Gillardo opened this issue Apr 17, 2020 · 5 comments · May be fixed by #41
Open

Large files failing when trying to return JSONObject #25

Gillardo opened this issue Apr 17, 2020 · 5 comments · May be fixed by #41

Comments

@Gillardo
Copy link

NOTE: Yes i have already got the android largeHeap = true in my manifest file

Platform: Android

I am selecting a 46MB file so i can copy it using my own code. Problem is that this plugin is trying to return the data for the file when you pick the file, and this is causing the app to crash

    java.lang.OutOfMemoryError: Failed to allocate a 256959896 byte allocation with 25165824 free bytes and 158MB until OOM, target footprint 395341816, growth limit 536870912
        at java.util.Arrays.copyOf(Arrays.java:3257)
        at java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:124)
        at java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:448)
        at java.lang.StringBuilder.append(StringBuilder.java:137)
        at org.apache.cordova.NativeToJsMessageQueue$JsMessage.buildJsMessage(NativeToJsMessageQueue.java:518)
        at org.apache.cordova.NativeToJsMessageQueue$JsMessage.encodeAsJsMessage(NativeToJsMessageQueue.java:535)
        at org.apache.cordova.NativeToJsMessageQueue.popAndEncodeAsJs(NativeToJsMessageQueue.java:191)
        at org.apache.cordova.NativeToJsMessageQueue$EvalBridgeMode$1.run(NativeToJsMessageQueue.java:366)
        at android.app.Activity.runOnUiThread(Activity.java:6974)
        at org.apache.cordova.NativeToJsMessageQueue$EvalBridgeMode.onNativeToJsMessageAvailable(NativeToJsMessageQueue.java:364)
        at org.apache.cordova.NativeToJsMessageQueue.enqueueMessage(NativeToJsMessageQueue.java:249)
        at org.apache.cordova.NativeToJsMessageQueue.addPluginResult(NativeToJsMessageQueue.java:238)
        at org.apache.cordova.CordovaWebViewImpl.sendPluginResult(CordovaWebViewImpl.java:311)
        at org.apache.cordova.CallbackContext.sendPluginResult(CallbackContext.java:61)
        at org.apache.cordova.CallbackContext.success(CallbackContext.java:79)
        at com.cyph.cordova.Chooser.onActivityResult(Chooser.java:132)

If you look at line 132, you will see this line

this.callback.success(result.toString());

I belive this is because calling toString to create the JSON object as a string with this much data is too much.

Can i ask why the data is returned? Should this not be a parameter on the getFile method? Or can we have another method getFileWithoutData instead to not break existing calls?

If i update my plugin file locally and change line 123 from

String base64 = Base64.encodeToString(bytes, Base64.DEFAULT);

to

String base64 = ""; // Base64.encodeToString(bytes, Base64.DEFAULT);

Then this now works
@Smoke1987
Copy link

The following must be added to config.xml to prevent crashing when selecting large files on Android:

<platform name="android">
 <edit-config
   file="app/src/main/AndroidManifest.xml"
   mode="merge"
   target="/manifest/application">
   <application android:largeHeap="true" />
 </edit-config>
</platform>

https://ionicframework.com/docs/native/chooser

@Smoke1987
Copy link

In my case, files over 100 megabytes are selected without problems

@zubinraja
Copy link

zubinraja commented May 14, 2021 •
edited
Loading

I have mentioned < application android:largeHeap="true" >
still app crash when selecting 100MB+ size file.

@capc0
Copy link

capc0 commented Feb 21, 2022

any updates or known workarounds for this issue?

@capc0
Copy link

capc0 commented Feb 21, 2022

I guess it is possible to use getFileMetadata which does not include the data, and then perform the binary data extraction within your own app (with error handling)

capc0 added a commit to capc0/cordova-plugin-chooser that referenced this issue Feb 21, 2022
@capc0
Gracefully handle Android OOM errors
9c8ffd0 
cyph#25
@capc0 capc0 linked a pull request Feb 21, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gracefully handle Android OOM errors capc0/cordova-plugin-chooser
4 participants
@Gillardo @zubinraja @Smoke1987 @capc0