Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Chromium link data not refreshed since Oct 2023 #29460

Closed
MikeMcC399 opened this issue May 2, 2024 · 10 comments
Closed

Download Chromium link data not refreshed since Oct 2023 #29460

MikeMcC399 opened this issue May 2, 2024 · 10 comments

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented May 2, 2024

Current behavior

The Cypress Launchpad menu Help > Download Chromium menu item links to
https://vikyd.github.io/download-chromium-history-version/#/
which shows stale data.
For instance the latest Linux x64 version of Chromium is shown as
version 121.0.6158.0 position: 1231300 from October 2023.

image

Desired behavior

The Cypress Launchpad menu Help > Download Chromium menu item should provide up-to-date information for downloading Chromium.

Perhaps the following link is an appropriate alternative?

https://www.chromium.org/getting-involved/download-chromium/

Test code to reproduce

Execute

npx cypress open --browser electron

In Cypress Launchpad menu select Help > Download Chromium which links to https://on.cypress.io/chromium-downloads and forwards to https://vikyd.github.io/download-chromium-history-version/#/

Cypress Version

13.8.1

Node version

v20.12.2 LTS

Operating System

Ubuntu 22.04.4 LTS

Debug Logs

No relevant information in debug logs.

Other

  1. Ubuntu provides Chromium as a snap package
    https://code.launchpad.net/~chromium-team/chromium-browser/+git/snap-from-source

  2. Puppeteer > Supported browsers shows that it has transitioned from supporting "Chromium" (last supported version 112) to instead supporting "Chrome for Testing" (last supported version 124).

@jennifer-shehane
Copy link
Member

We can easily update this to be whatever we want internally via our on link rerouting. I wonder what happened to that website because it used to be up to date. :/

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

I wonder what happened to that website because it used to be up to date. :/

@jennifer-shehane
Copy link
Member

jennifer-shehane commented May 3, 2024

@MikeMcC399 Ah, yah we had the same issue with our site. Just wasn't worth updating after the omahaproxy changed.

@jennifer-shehane
Copy link
Member

I know you can't see this link, but this is being updated here: https://github.com/cypress-io/cypress-services/pull/8325 And would hopefully be released on Monday.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

The quick fix would be to change

https://on.cypress.io/chromium-downloads

to point to

https://www.chromium.org/getting-involved/download-chromium/

Long-term I wonder if the Cypress Launchpad should actually offer a Help link to Download Chromium as other browsers such as Chrome seem to be more in demand for testing compared to Chromium. Perhaps this link should be removed (would probabyl fall into the category "breaking change" though)?

@jennifer-shehane jennifer-shehane added the stage: needs review The PR code is done & tested, needs review label May 3, 2024
@jennifer-shehane
Copy link
Member

Mostly the intention of this is to offer a way to download lower versions of Chrome to test if something is working in an earlier version that's not broken.

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

This issue is closed, however I'm not seeing any change to https://on.cypress.io/chromium-downloads so far, so the issue still exists.

@jennifer-shehane
Copy link
Member

jennifer-shehane commented May 7, 2024

Yah I missed the release by like an hour. Will probably release on Wednesday.

@jennifer-shehane jennifer-shehane removed the stage: needs review The PR code is done & tested, needs review label May 7, 2024
@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

Thanks for the explanation!

@MikeMcC399
Copy link
Contributor Author

@jennifer-shehane

The new redirect to https://www.chromium.org/getting-involved/download-chromium/ is now effective:

image

so this issue can now be closed.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants