fix: ensure that each js file served up by vite dev server has an inline sourcemap #30606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-in-vite-dev-server-has-a-sourcemap
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/fix/ensure-that-each-served-js-file-in-vite-dev-server-has-a-sourcemap
|
| Run status |
|
| Run duration | 17m 41s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
77
|
Skipped
|
0
|
Passing
|
5588
|
| View all changes introduced in this branch ↗︎ | |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
AtofStryker
reviewed
Nov 13, 2024
Unfortunately, no that is more complicated to resolve however this will get us where we need to get to in order to properly have sourcemaps available in the protocol space. |
mschile
reviewed
Nov 13, 2024
mschile
reviewed
Nov 13, 2024
mschile
reviewed
Nov 13, 2024
…-in-vite-dev-server-has-a-sourcemap
ryanthemanuel
commented
Nov 13, 2024
mschile
approved these changes
Nov 13, 2024
ryanthemanuel
commented
Nov 13, 2024
…-in-vite-dev-server-has-a-sourcemap
AtofStryker
approved these changes
Nov 14, 2024
ryanthemanuel
deleted the
ryanm/fix/ensure-that-each-served-js-file-in-vite-dev-server-has-a-sourcemap
branch
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
We have a custom vite dev server plugin that transforms JS files to include inlined source maps but there were two scenarios that were missed with this plugin:
This PR resolves both of these scenarios.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?