-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with channels 3 #68
Comments
Websocket breaking in channels v3 seems to stem from this issue. This can be fixed by adding the websocket url in routing.py as such: urlpatterns = [
url(r'^ws/progress/(?P<task_id>[\w-]+)/?$', consumers.ProgressConsumer.as_asgi()),
] Now, either we can do that and drop support for channels v2, or do a try/except clause and support both. Thoughts @czue @OmarWKH? |
I guess if there's no major downside and it's a simple try/catch then supporting both for now seems better? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #56.
Websocket breaks when channels 3 is installed. Channels 2.4.0 works.
The text was updated successfully, but these errors were encountered: